[Bf-committers] [PATCH] use ADD_SUBDIRECTORY() instead of SUBDIRS() in the cmake files

[Alexander Neundorf]

On Thursday 14 May 2009, Benoit Bolsee wrote:
> >On Saturday 09 May 2009, Alexander Neundorf wrote:
> >> On Tuesday 28 April 2009, Alexander Neundorf wrote:
> >> > On Monday 27 April 2009, Shaul Kedem wrote:
> >> > > Now lets discuss the actual patch: does it make anything fail as
>
> far
>
> >> > > as you know?
> >> >
> >> > It builds and I didn't notice any breakage (but I don't know that
>
> much
>
> >> > about blender yet).
> >>
> >> I did a little bit more work on it yesterday, there was one problem
>
> in the
>
> >> patch, updated patch is attached to the bug report (subdirs-2.diff):
>
> http://projects.blender.org/tracker/index.php?func=detail&aid=18633&grou
> p_i
>
> >>d=9&atid=127
> >>
> >> I also compared the results, the binary are not binary identical, but
>
> I
>
> >> also compared the build log, and the only difference I found was a
> >> different order of building for a few files.
> >> (this might be due to the slightly different order in which the
>
> directories
>
> >> are processed now).
> >>
> >> It would be nice if somebody could give it a try and see if
>
> everything is
>
> >> ok. I didn't notice any problems.
> >
> >Anybody interested ?
> >It would be nice if somebody could have a look and apply it, there are
>
> more
>
> >things which could be cleaned up a bit in the cmake files.
> >(but I don't want to post patches before that)
>
> I tested the patch and compiled in Win32 with MSVC2008.
> It works well. The release build is about the same size and is just a
> little bit slower than the scons build.
> As usual the debug build crashes because of the Python dll: it links
> with python25.dll while it should use python25_d.dll.
>
> Would you be able to fix that problem?

Not today, but I'll have a look when I find time.

Alex