[Bf-committers] Request for removing restrictions in edge rotation and face joining.

[Vilem Novak]

Hello, I already submitted patch for the edge rotation once, because I also found it annoying when modelling. It wasn't reviewed however.
The patch is here:
https://projects.blender.org/tracker/index.php?func=detail&aid=18016&group_id=9&atid=127

It's number in tracker is #18016

V.

> ------------ Původní zpráva ------------
> Od: Banlu Kemiyatorn <object at gmail.com>
> Předmět: Re: [Bf-committers] Request for removing restrictions in edge rotation
> and face joining.
> Datum: 19.3.2009 18:31:58
> ----------------------------------------
> On Thu, Mar 19, 2009 at 11:59 PM, joe <joeedh at gmail.com> wrote:
> > Could you send us a patch of what you did?
> >
> > Joe
> 
> Hi,
> 
> Here it is. It just remove 5 lines from 2 functions.
> 
> Thanks!
> 
> 
> > On Thu, Mar 19, 2009 at 3:00 AM, Banlu Kemiyatorn <object at gmail.com> wrote:
> >> On Thu, Mar 19, 2009 at 4:55 AM, joe <joeedh at gmail.com> wrote:
> >>> Hrm.  I'd file a bug report then.
> >>>
> >>> Joe
> >>>
> >>> On Wed, Mar 18, 2009 at 2:05 PM, Banlu Kemiyatorn <object at gmail.com> wrote:
> >>>> On Thu, Mar 19, 2009 at 2:16 AM, joe <joeedh at gmail.com> wrote:
> >>>>> There's a threshold for how coplanier the two triangles have to be,
> >>>>> this used to be too low by default, and it sounds like it perhaps
> >>>>> still is.
> >>>>>
> >>>>> Joe
> >>
> >>
> >> Hi,
> >>
> >> I think void join_triangles(void) only uses the threshold value for complex
> >> island and my cases it didn't but was rejected by a convex() test.
> >>
> >> I also have if(Inpf(face[0]->n,face[1]->n) <= 0.000001) in edge_rotate()
> >> commented didn't cause me any problem for a while.
> >>
> >> It is fine to live with that except that now I am teaching people about
> >> managing tris and edge loop to control sub-d and then I have to ask them
> >> to use my branch which I can't build a windows version for them. So I
> >> really wish
> >> these restrictions will be gone from 2.49. The only thing I am not certain
> >> is if these comments will cause any trouble to some existing batch
> processes.
> >> So I wonder if I can just have them commented of if a patch that allow an
> >> option to force the joining and the rotation is welcome.
> >>
> >> Thanks.
> >> _______________________________________________
> >> Bf-committers mailing list
> >> Bf-committers at blender.org
> >> http://lists.blender.org/mailman/listinfo/bf-committers
> >>
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-committers
> >
> 
> 
> 
> -- 
>     .----.     Banlu Kemiyatorn
>   /.../\...\   Free Software Yogi
>  |.../  \...|  漫画家 GZSC
>  |../    \..|  http://groundzerostudiocomplex.blogspot.com
>   \/      \/   http://qstx.blogspot.com
> 
> 
>