[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [22068] branches/blender2.5/blender/source /blender/makesrna/intern/rna_space.c: 2.5 Background Image:

[Thomas Dinges]

Hey,
i am sorry.
I also would rather have used an NC_WINDOW Notifier but there allready 
was 1 notifer in there for the "image" propertie and it was an Object one.
;-)
So, changing it to NC_WINDOW?

cheers,

DingTo

Matt Ebb schrieb:
> This doesn't look correct - changing the background image should not  
> be sending an OBJECT notifier - that's for when actual objects are  
> manipulated.
>
> Abusing these notifier categories will make the whole system useless,  
> so it's better to do things right here! :)
>
> cheers,
>
> Matt
>
>
> On 31/07/2009, at 5:19 AM, Thomas Dinges wrote:
>
>   
>> Revision: 22068
>>          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=22068
>> Author:   dingto
>> Date:     2009-07-30 21:19:21 +0200 (Thu, 30 Jul 2009)
>>
>> Log Message:
>> -----------
>> 2.5 Background Image:
>>
>> * Added notifier.
>>
>> Modified Paths:
>> --------------
>>    branches/blender2.5/blender/source/blender/makesrna/intern/ 
>> rna_space.c
>>
>> Modified: branches/blender2.5/blender/source/blender/makesrna/intern/ 
>> rna_space.c
>> ===================================================================
>> --- branches/blender2.5/blender/source/blender/makesrna/intern/ 
>> rna_space.c	2009-07-30 18:52:21 UTC (rev 22067)
>> +++ branches/blender2.5/blender/source/blender/makesrna/intern/ 
>> rna_space.c	2009-07-30 19:19:21 UTC (rev 22068)
>> @@ -477,24 +477,29 @@
>> 	prop= RNA_def_property(srna, "image_user", PROP_POINTER,  
>> PROP_NEVER_NULL);
>> 	RNA_def_property_pointer_sdna(prop, NULL, "iuser");
>> 	RNA_def_property_ui_text(prop, "Image User", "Parameters defining  
>> which layer, pass and frame of the image is displayed.");
>> +	RNA_def_property_update(prop, NC_OBJECT, NULL);
>> 	
>> 	prop= RNA_def_property(srna, "x_offset", PROP_FLOAT, PROP_NONE);
>> 	RNA_def_property_float_sdna(prop, NULL, "xof");
>> 	RNA_def_property_ui_text(prop, "X Offset", "Offsets image  
>> horizontally from the view center");
>> +	RNA_def_property_update(prop, NC_OBJECT, NULL);
>> 	
>> 	prop= RNA_def_property(srna, "y_offset", PROP_FLOAT, PROP_NONE);
>> 	RNA_def_property_float_sdna(prop, NULL, "yof");
>> 	RNA_def_property_ui_text(prop, "Y Offset", "Offsets image  
>> vertically from the view center");
>> +	RNA_def_property_update(prop, NC_OBJECT, NULL);
>> 	
>> 	prop= RNA_def_property(srna, "size", PROP_FLOAT, PROP_NONE);
>> 	RNA_def_property_float_sdna(prop, NULL, "size");
>> 	RNA_def_property_ui_text(prop, "Size", "Scaling factor for the  
>> background image.");
>> 	RNA_def_property_range(prop, 0.0, FLT_MAX);
>> +	RNA_def_property_update(prop, NC_OBJECT, NULL);
>> 	
>> 	prop= RNA_def_property(srna, "transparency", PROP_FLOAT, PROP_NONE);
>> 	RNA_def_property_float_sdna(prop, NULL, "blend");
>> 	RNA_def_property_ui_text(prop, "Transparency", "Amount to blend the  
>> image against the background color.");
>> 	RNA_def_property_range(prop, 0.0, 1.0);
>> +	RNA_def_property_update(prop, NC_OBJECT, NULL);
>>
>> }
>>
>>
>>
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>>     
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
>