[Bf-committers] [PATCH] cmake build: use find_package() instead of include()

Campbell Barton ideasman42 at gmail.com
Wed Jul 8 10:35:20 CEST 2009


Hi Alex, I committed one of your patches a while ago, both these
patches are applied in blender 2.5.
Since your interested in helping maintain CMake could you submit
patches to the patch tracker? - it reduces noise on the mailing list,
and keeps you informed if you patch is applied without having to check
the commit logs.

For new patches mailing here is still fine, just add a link to the
tracker rather then attaching.

On Tue, Jul 7, 2009 at 9:32 AM, Alexander Neundorf<neundorf at kde.org> wrote:
> On Saturday 27 June 2009, Alexander Neundorf wrote:
>> Hi,
>>
>> the attached patch replaces the include() commands for the FindXXX.cmake
>> modules with the appropriate find_package(Foo) calls.
>> This doesn't change the behaviour, but gives more features.
>> E.g. you could now say
>> find_package(JPEG REQUIRED)
>> and cmake will abort with an error if the package is not found.
>> Also it makes it clearer what is going on.
>>
>> Additionally the patch removes the line
>>  INCLUDE(${CMAKE_ROOT}/Modules/Platform/Windows-cl.cmake)
>> in the Windows if-branch.
>> Why was this there ? This file should be included anyway under Windows when
>> using the MS compiler.
>
> Comments ?
>
> Alex
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>



-- 
- Campbell


More information about the Bf-committers mailing list