[Bf-committers] [PATCH] cmake build: use find_package() instead of include()

Alexander Neundorf neundorf at kde.org
Tue Jul 7 18:32:49 CEST 2009


On Saturday 27 June 2009, Alexander Neundorf wrote:
> Hi,
>
> the attached patch replaces the include() commands for the FindXXX.cmake
> modules with the appropriate find_package(Foo) calls.
> This doesn't change the behaviour, but gives more features.
> E.g. you could now say
> find_package(JPEG REQUIRED)
> and cmake will abort with an error if the package is not found.
> Also it makes it clearer what is going on.
>
> Additionally the patch removes the line
>  INCLUDE(${CMAKE_ROOT}/Modules/Platform/Windows-cl.cmake)
> in the Windows if-branch.
> Why was this there ? This file should be included anyway under Windows when
> using the MS compiler.

Comments ?

Alex


More information about the Bf-committers mailing list