[Bf-committers] BGE: Can we have a centralized call KX_KetsjiEngine::OnResize() (please :)

blender at erwincoumans.com blender at erwincoumans.com
Wed Feb 4 20:13:37 CET 2009


Hi Dalai, 

I'm fine with it, but do you have an idea how much work it is?
If it requires a huge amount of refactoring, it is probably not worth it. 

Benoit, if you read this, do you have any feedback?
Thanks,
Erwin 


Brecht Van Lommel writes: 

> Hi Dalai, 
> 
> I don't think there is anything like this, seems fine to add it. This
> kind of code change is OK to do as part of the fisheye patch really,
> it's often better to improve the code than just copy hacks from other
> places.. and probably at this point you know more about this particular
> part of the game engine code than anyone else reading this list :). 
> 
> Brecht. 
> 
> On Tue, 2009-02-03 at 21:07 -0500, Dalai Felinto wrote:
>> Hi. 
>> 
>> A lot of times I see the need of checking for viewport size changes
>> during BGE code.
>> For example in RAS_2DFilterManager.cpp and in the *wip* Fisheye code.
>> But I'm pretty sure it happens in all functions that rely on the size
>> of the viewport for render purposes. 
>> 
>> I know that checking viewport size changes and getting power-of-2
>> texture sizes related to that are fast.
>> However I think it would be better (easier to code/maintain) if we
>> could centralize it all in a KX_KetsjiEngine::OnResize() (or any other
>> name). 
>> 
>> Does anyone agree/have a problem with that? There is any reason
>> (historical, maybe?) to not have it?
>> Do we already have something like that (i couldn't find it)? 
>> 
>> Cheers,
>> Dalai 
>> 
>> http://blenderecia.orgfree.com
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers 
>> 
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
 



More information about the Bf-committers mailing list