[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [22816] branches/blender2.5/blender: Tweaked layout of game properties.

Campbell Barton ideasman42 at gmail.com
Thu Aug 27 11:34:33 CEST 2009

Theres a few things that Im not so sure of in this commit.

Using consistent terms like start/end vs tip/root, is good between
user interface and API.
But changes...
gloss -> gloss_amount # descriptive but not needed for api names.
transparent_shadows -> receive_transparent_shadows # correct but
overly verbose for an api IMHO

We should also better document how booleans should be named.
a while back we agree'd on "use_" as a suffix, rather then "do_",
"enable_", "toggle_" etc.
However the RNA api is currently inconsistent, with this.

# is misleading to read when reading a script, the UI makes it obvious
its a toggle but
# also confusing texture vs textures
 if material.texture:  ....
 if material.use_texture:  ....

These changes also break the povray script, no big deal since its an
example but try avoid this.
When renaming api functions its good to grep for their use in svn to
make sure at least bundled scripts dont break.

- Campbell

On Thu, Aug 27, 2009 at 1:46 AM, William Reynish<william at reynish.com> wrote:
> Revision: 22816
>          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=22816
> Author:   billrey
> Date:     2009-08-27 10:46:39 +0200 (Thu, 27 Aug 2009)
> Log Message:
> -----------
> Tweaked layout of game properties. The Add button is now at the top, meaning it doesn't move around - this is also more consistent with constraints/modifiers etc. Used the same 'box' layout as constraints/modifiers.
> Also ported some name changes from the materials UI script to RNA to keep these consistent. Animation editors always show the RNA name after all, so it's good to keep the names similar.
> Modified Paths:
> --------------
>    branches/blender2.5/blender/release/ui/buttons_material.py
>    branches/blender2.5/blender/release/ui/space_logic.py
>    branches/blender2.5/blender/source/blender/editors/animation/anim_ops.c
>    branches/blender2.5/blender/source/blender/makesrna/intern/rna_material.c

More information about the Bf-committers mailing list