[Bf-committers]  branches/blender2.5/blender: fix for build problem with audiospace and implicit declaration.
nicholasbishop at gmail.com
Mon Aug 10 20:18:34 CEST 2009
I agree with his change; it seems like a bad idea to change all the
build references for audio to include a reference to the *internal*
header directory for audaspace. If the directory structure is at some
point changed, it's better to have it just change in the external
header (AUD_C-API.h). Also, the hardcoded path is still relative, so I
don't see how it's any more hardcoded either way, you're still
explicitly referencing a file.
It's not a huge deal either way, but I prefer not to alter a bunch of
CMakeLists unnecessarily, so some consensus would be good :)
On Mon, Aug 10, 2009 at 1:40 PM, GSR<gsr.b3d at infernal-iceberg.com> wrote:
> ideasman42 at gmail.com (2009-08-10 at 0650.48 +0200):
>> Revision: 22334
>> Author: campbellbarton
>> Date: 2009-08-10 06:50:48 +0200 (Mon, 10 Aug 2009)
>> Log Message:
>> fix for build problem with audiospace and implicit declaration.
>> -#include "AUD_Space.h"
>> +#include "./intern/AUD_Space.h"
> Why do you hardcode the path? It was changed to non hardcoded
> directory in r22331. And the commit log explicitly mentioned other
> build systems should be checked.
> Bf-committers mailing list
> Bf-committers at blender.org
More information about the Bf-committers