[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [14752] trunk/blender/release/scripts/ vrml97_export.py: fix for [#6692] vrml (.wrl) export bug in V2.44 release

Michalis Kamburelis michalis.kambi at gmail.com
Sat May 10 04:43:31 CEST 2008

Some comments from the author of this patch (#10569, "Improved UI for
vrml97_export.py") after seeing commits 14752 and 14757:

Chris Want wrote:
> Campbell Barton wrote:
>> Revision: 14752
>>           http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=14752
>> Author:   campbellbarton
>> Date:     2008-05-08 22:51:22 +0200 (Thu, 08 May 2008)
>> Log Message:
>> -----------
>> fix for [#6692] vrml (.wrl) export bug in V2.44 release
>> patch from Michalis Kamburelis with some minor edits
> As the maintainer of this script, I would have appreciated
> some consultation before you committed this. I don't have
> time to test this before release either. Looking at the
> diff I can see immediately that it agrivates an earlier bug
> that I had treated (#4922, where I removed precision
> truncation). It never hurts to do a 'svn log' when you
> are touching a file somebody else maintains.

Changing the output float format was not in my original patch. I see it
fixed back to normal "%s" after commit 14757, so it's Ok now.

> I hope at the very least that you have left the regular vmrl
> coordinate system as the default one, rather than making the
> blender coordinate system the new default.

My patch deliberately set export_rotate_z_to_y by default to true. So
the default behavior of the script was exactly like before the patch,
that is the model was rotated to the VRML coordinate system.

But the newer commit 14757 changes it to false... If you want to keep
VRML coordinate as the default one (and I agree with Chris, this should
be the default) change it back, i.e. make the line

  export_rotate_z_to_y = Draw.Create(1)

IOW, if you would just apply my patch exactly as it was submitted
(default export_rotate_z_to_y = 1 and no change to float output)
everything would be perfect :)


More information about the Bf-committers mailing list