[Bf-committers] Modifier stack refactor

[Martin Poirier]

Hi,

--- On Mon, 6/23/08, Diego Hernan Borghetti <bdiego at gmail.com> wrote:

> On Mon, 23 Jun 2008, Campbell Barton wrote:
> 
> Hello Ben:
> 
> > Hey Ben,
> > Agree splitting up modifier.c into files in nice but
> is this something
> > thats holding back further development?
> > If its mainly an organizational change, it could be
> better to wait
> > until 2.47 is out.
> 
> I see this like a good thing, but not for the 2.47 because
> in the Node 
> refactor we have some problem with the build system
> (windows, linux, 
> mac... scons, make, cmake) and I want avoid this.
> 
> _BUT_ I don't see any problem if you want to work in
> trunk and keep a 
> clean commit policy.
> 
> With "clean commit policy" I mean, split what
> it's a modifier bugfix and 
> what it's a "refactor bugfix".
> 
> If you can do that, it's easy for me track the commit
> and only merge the 
> bugfix into the 2.47 branch.

Bugfixes will probably be hard to merge if the code is split up.

The refactor can always happen in a new branch (to be merged in trunk after 2.47 release) if it would impact 2.47 too much.

Martin