[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [13715] trunk/blender/source/blender/src/ drawimage.c: Images in the image editor were being draw with the wrong glBlendFunc() command

[Joe Eagar]

Stéphane SOPPERA wrote:
> Joseph Eagar a écrit :
>   
>> Revision: 13715
>>           http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=13715
>> Author:   joeedh
>> Date:     2008-02-16 17:44:41 +0100 (Sat, 16 Feb 2008)
>>
>> Log Message:
>> -----------
>> Images in the image editor were being draw with the wrong glBlendFunc() command
>> in draw-alpha mode. This would cause key alpha images to draw badly.
>>   
>>     
> Joseph,
>
> Actually you rolled back a correction make by Ton for the bug 4734:
> http://projects.blender.org/tracker/index.php?func=detail&aid=4734
>
> The bug was that premultiplied-images were drawn badly ;-)
>
> Here is the commit mail for the previous correction:
> http://lists.blender.org/pipermail/bf-blender-cvs/2006-July/007386.html
>
> Maybe a better solution to this issue would be to have a setting on 
> image/viewer to specify if it's pre-multiplied or not, and use the 
> correct blending mode according to this setting.
>
> Regrads,
> Stéphane
>
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
>   
I just tested the .blend in the bug report. . .no ugly black lines for 
me.  On the other hand, the GL_ONE fix really messed up drawing key images.

Joe