[Bf-committers] _LARGEFILE_SOURCE

Giuseppe Ghibò ghibo at mandriva.com
Mon Feb 18 17:03:54 CET 2008

Campbell Barton ha scritto:
> Not sure this got to bf-commiters?
> From our conversation on IRC, most apps that do ./configure; make;
> make install will set largefile defines anyway, why dont we just make
> this default? - if it breaks something (which seems unlikely since
> many distro's use it) it can be reversed.
> If other OS's don't like it then the flags can be set for those os's
> specifically.

OK, could be the default. I think I'll readapt the patch so that the:


will be global (in that way will be the default) and not only to 
linux2-config.py. But I think it's worthwhile to keep as an added
option to scons, as AFAIK I'm not aware of any "C define" reverting the 
macro. Indeed it's not even checked whether it's set to 0 or 1, but just 
that it's defined.


> On Feb 17, 2008 10:33 PM, Giuseppe Ghibò <ghibo at mandriva.com> wrote:
>> I've just seen Campbell committed a subset of my patch for bug #6811.
>> Indeed it's also important
>> that the I/O or (l)lseek() functions in blender are also switched to
>> blender is not only able to show largefiles with right size in the file
>> requester, but also to deal with them.
>> The right way to do this is to include the patch as whole, as the key is
>> to pass the
>> right flags to CPPDEFINES and thus propagate to every file compiled.
>> I've checked this
>> twice and the right place is both tools/Blender.py as well as
>> extern/verse/dist/SConstruct
>> (otherwise 'verse' would be left out from the largefile). Note also that
>> 3rd party libraries
>> which relies on "configure" already use and detect the LARGEFILE option,
>> so once the patch is
>> applied everything should be already in sync.
>> Bye
>> Giuseppe.

More information about the Bf-committers mailing list