[Bf-committers] Color correction in sequencer.

[Xavier Thomas]

Yes, that is what I ment but is it ok to add an UI parameter "ofset" with is
button "Inv ofset" at the side of the Lift gamma and gain parameters because
the UI will get really charged.

And what about an image treatment library, because I already have made this
function in my keyer node and crating a color correction node with these
controls might be usefull also: this will result in a lot of code
duplication.


2008/12/10 Dalai Felinto <dfelinto at gmail.com>

> Hi Xavier.
>
> Can't you do a do_version()?
> In readfile.c you can see a lot of parameters that need to be updated
> over Blender version.
> If what you need is a simple offset for old blender files work in the
> same way as new blender files (with this bug fixed), this should work.
>
> I didn't see the bug or this part of the code, but do_version()
> sometimes is the better way to go.
>
> Cheers,
> Dalai
> http://blenderecia.orgfree.com
>
> 2008/12/10 Xavier Thomas <xavier.thomas.1980 at gmail.com>:
> > Hello,
> >
> > Lately, I was trying to implicate me in blender developement,  and
> begining
> > with small things (after the keyr node) I  desided to correct this bug:
> >
> http://projects.blender.org/tracker/index.php?func=detail&aid=18010&group_id=9&atid=125
> >
> > Basicly the lift parameter of color correction in sequencer works more
> like
> > a "value" color correction than a "lift" (exept that it work on RGB
> channel
> > separately so I think "ofset" is more apropriate then "value")
> >
> > Fixing it would be simple but old files that use this parameter will have
> a
> > diferent render result, and after discussing with Matt Ebb on IRC it
> seems
> > that this is not acceptable.
> > So the only solution to have a proper color correction in the sequencer
> is
> > to add an "ofset" parameter. Is this OK ? (maybe the UI will get too
> > compact)
> >
> > Further, why do not put this kind of function in an image library so it
> will
> > be accesible form other part of the program (nodes and maybe image
> editor)
> > like the quick blur function in the nodes CMP_util.h
> >
> > Sorry to disturb, I know lot of you are really buzzy but I prefer to get
> > good directions before coding.
> >
> > Thanks
> >
> > Xavier
> >
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-committers
> >
> >
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-committers/attachments/20081210/d5112c13/attachment.htm