[Bf-committers] Various build-related remarks

[Cyril Brulebois]

Hi,

some quick remarks:

SCons is moving Options to Variables, which has been initiated in
0.98.1:
| Add a Variables object as the first step towards deprecating the
| Options object name.  Similarly, add BoolVariable(), EnumVariable(),
| ListVariable(), PackageVariable() and PathVariable() functions
| as first steps towards replacing BoolOption(), EnumOption(),
| ListOption(), PackageOption() and PathOption().

There's a compatibility layer at the moment, but the following code
fails. Attached is a proposed patch against trunk (r14554), as proposed
by Mark Brown (see [1]):
| # From tools/btools.py
| import SCons.Options.BoolOption
| BoolOption = SCons.Options.BoolOption

outputs:
| kibi at waity:~/upstream/blender$ scons
| scons: Reading SConscript files ...
| ImportError: No module named BoolOption:
|   File "/home/kibi/upstream/blender/SConstruct", line 42:
|     import tools.btools
|   File "/home/kibi/upstream/blender/tools/btools.py", line 5:
|     import SCons.Options.BoolOption

 1. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=477912


There are other deprecation warnings:
| scons: warning: The env.Copy() method is deprecated; use the env.Clone() method instead.


You may also want to drop that flag from C_WARN:
| cc1plus: warning: command line option "-Wdeclaration-after-statement" is valid for C/ObjC but not for C++
gets printed for every single file with gcc 4.3.1. Not that I'm
complaining, I already patched it, but I thought you might want to know
about that.

Cheers,

-- 
Cyril Brulebois
-------------- next part --------------
Index: tools/btools.py
===================================================================
--- tools/btools.py	(r?vision 14554)
+++ tools/btools.py	(copie de travail)
@@ -2,7 +2,6 @@
 import os
 import os.path
 import SCons.Options
-import SCons.Options.BoolOption
 try:
     import subprocess
 except ImportError:
@@ -13,7 +12,7 @@
 import sys
 
 Options = SCons.Options
-BoolOption = SCons.Options.BoolOption
+BoolOption = Options.BoolOption
 
 def print_arguments(args, bc):
     if len(args):
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.blender.org/pipermail/bf-committers/attachments/20080426/f3e82dce/attachment.pgp