[Bf-committers] Patch #8034 still not committed

[Daniel Genrich]

Hello Markus,

I was the one pre-reviewing your patch.

Let  me answer your questions:

1. "Are there any free values left?" - just take a look into 
DNA_material_types.h and you will see it. HINT: integer has 32 bits, 
short 16. And these are constants, not macros. ;)

Please clean up the patch according to my suggestions if you want to 
have it included.

Thank you very much!
Daniel


markus.ilmola at pp.inet.fi schrieb:
> Looking at the patch tracker it seems that my patch #8034 is still not 
> committed
> to the svn. The reason seems to be that the new macro "MA_HALO_SOFT" has the 
> same 
> value as existing macro "MA_RADIO". So what value should it have? Is there 
> even 
> any free values left? I would like to point out that some other existing 
> macros 
> have overlapping value too: "MA_HALOPUNO" and "MA_ONLYCAST" have the same 
> value 
> 0x2000 and "MA_NOMIST" and "MA_HALO_SHADE" have the same value 0x4000.
>
> ps. Can I get someone assigned to my other patch: #8540
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
>