[Bf-committers] [bf-blender-Patches][6842] A new procedural texture implementation to generate tiling patterns

[Ahmad Kabani]

I'm not familiar with how subversion levels work. Do you normally revert it to 0 after a release? It didn't seem like it since it is now at 7 in latest SVN checkout. I may have missed it while away from the source code for a while.

For now, I'll use (main->versionfile < 245) and notify users that appending from files of older versions may not work correctly (which it is anyway).

Will someone automatically fix do_versions() if the patch is integrated into blender OR is that my responsibility to provide as part of the patch?

----- Original Message ----
From: Joe Eagar <joeedh at gmail.com>
To: bf-blender developers <bf-committers at blender.org>
Sent: Friday, November 9, 2007 10:48:08 AM
Subject: Re: [Bf-committers] [bf-blender-Patches][6842] A new procedural texture implementation to generate tiling patterns

Well, if(main->versionfile <= 245 || main->subversionfile < 4)sounds really stupid to me to begin with.  "If version is less then or equal 2.45 or subversion is less then 4).  What if version is, say, 2.6?  well "if version is less then of equal 2.45) would be false but "if subversion is less then 4" could still be true.

Joe


Ahmad Kabani wrote:
> Hi guys, 
>
> I have a quick question. In readfile.c, do_versions(), the main->subversionfile doesn't seem to reflect the correct subversion level stored in the file OR the subversion level seems to be stored incorrectly. This patch has existed since before 2.45 was released. Some people noted that appending a material containing the new Tiles texture would not work. I found that none of the texture parameters were being reloaded... actually all of them were reset to defaults because I was doing a check like so: 
>
>    if(main->versionfile != 245 || main->subversionfile < 4)
>        OR 
>    if(main->versionfile <= 245 || main->subversionfile < 4)
>
> The debugging statement at the top of the function reports subversion set to 0 instead of 7 (as defined in BKE_blender.h. I can temporarily fix my patch by changing the call to:
>
>    if(main->versionfile < 245)
>
> but this fixes only for files saved with the latest patch. Is there a better way I can resolve this?
>
>
> Ahmad
>
> P.S. I'm now at a point where I've run out of ideas for this. If people have comments and suggestions on how I can improve on the UI and functionality (new presets, better parameters) please feel free to let me know.
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around 
> http://mail.yahoo.com 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
>  

_______________________________________________
Bf-committers mailing list
Bf-committers at blender.org
http://lists.blender.org/mailman/listinfo/bf-committers

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com