[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [10936] branches/soc-2007-hcube: my firts commit.

[Chris Want]

Hi Csaba,

Just a couple of short comments:

Csaba Hruska wrote:
> Revision: 10936
>           http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=10936
> Author:   hcube
> Date:     2007-06-15 14:08:29 +0200 (Fri, 15 Jun 2007)
> 
> Log Message:
> -----------
> my firts commit.

This isn't a very informative commit message, be sure to always
indicate what you are commiting.

> Modified: branches/soc-2007-hcube/config/linux2-config.py
<SNIP>
>  ##
> -CC = 'gcc'
> -CXX = 'g++'
> +CC = 'gcc-4.1'
> +CXX = 'g++-4.1'

You should never commit user specific settings like this to the
repository. I don't usually use Scons, but I believe you can
put settings like this in a file called user-config.py
which isn't included in the repository (so that user
settings don't get committed by accident)... perhaps a Scons
user can confirm that this is the correct way to deal
with user specific settings?

Regards,
Chris