[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [10834] trunk/blender/source/gameengine/ Converter/BL_ArmatureObject.cpp: Applied patch [#5795] Parent to bone - Supplied by Monster.

[Ton Roosendaal]

Hi Charlie,

This is not really an improvement... you call an update for an entire  
armature just go get 1 bone matrix correct.

It's the typical case of "get things to work quick" that will frustrate  
you later.

I would have not approved on such patch. If this is truely important to  
add, then at least add a big warning comment on this change.

-Ton-


On 31 May, 2007, at 22:40, Charlie C wrote:

> Revision: 10834
>            
> http://projects.blender.org/plugins/scmsvn/viewcvs.php? 
> view=rev&root=bf-blender&revision=10834
> Author:   snailrose
> Date:     2007-05-31 22:40:59 +0200 (Thu, 31 May 2007)
>
> Log Message:
> -----------
> Applied patch [#5795] Parent to bone - Supplied by Monster.
>
> Modified Paths:
> --------------
>     trunk/blender/source/gameengine/Converter/BL_ArmatureObject.cpp
>
> Modified:  
> trunk/blender/source/gameengine/Converter/BL_ArmatureObject.cpp
> ===================================================================
> ---  
> trunk/blender/source/gameengine/Converter/BL_ArmatureObject.cpp	2007 
> -05-31 14:02:43 UTC (rev 10833)
> +++  
> trunk/blender/source/gameengine/Converter/BL_ArmatureObject.cpp	2007 
> -05-31 20:40:59 UTC (rev 10834)
> @@ -190,8 +190,9 @@
>
>  bool BL_ArmatureObject::GetBoneMatrix(Bone* bone, MT_Matrix4x4&  
> matrix) const
>  {
> -	// ton hack
> -	bPoseChannel *pchan= get_pose_channel(m_pose, bone->name);
> +	Object* par_arma = m_objArma;
> +	where_is_pose(par_arma);
> +	bPoseChannel *pchan= get_pose_channel(par_arma->pose, bone->name);
>
>  	if(pchan) {
>  		matrix.setValue(&pchan->pose_mat[0][0]);
>
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton at blender.org  
http://www.blender.org