[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/blenkernel/intern modifier.c blender/source/blender/src buttons_editing.c blender/source/blender/makesdna DNA_modifier_types.h

[Ben Batt]

Hi joeedh,

On 1/27/07, Joseph Eagar <joeedh at gmail.com> wrote:
>   =Displace modifier fix=
>
>   Whenever a displace modifier has an invalid UV name (for whatever reason) the
>   UV name is set to the active layer.  This is checked both in the UI code and
>   in the modifier exec code, so all bases are covered. For deleting a layer, this
>   required upgrading the layer delete code in the UI to properly preserve the
>   active layer, to prevent unwanted behaviour. I hope this is an ok solution.
>
>   Brecht, Ben you might want to look over and make sure I didn't break anything.  I don't
>   think I did, I tested as thouroughly as I could.
>

It seems pretty stable to me (aside from the one fix I just
committed). I'm just a little uncertain about setting the layer name
to the active UV layer when it's invalid - it seems like the modifier
setting could change unexpectedly, and users might have a hard time
figuring out why, or even what changed. Perhaps the modifier could
simply be disabled if UV coordinates are selected and no layer name is
given? What do you think?

Also, in your commit, you added a line to DNA_modifier_types.h:
"struct MemArena;". As far as I can tell this isn't needed, has it
been left over from something else?

Ben