[Bf-committers] BW input in Luma keyer

[Ton Roosendaal]

Hi Bob,

I noticed you test for buffer types (RGBA), but what you could do  
instead is following this convention:

instead of:
	inbuf= in[0]->data;
	if(inbuf->type!=CB_RGBA) return;

use:
	inbuf= typecheck_compbuf(in[0]->data, CB_RGBA);

     /* (in end of function) */
	if(inbuf!=in[0]->data)
			free_compbuf(inbuf);

I would consider it "bug", by default composite nodes accept any input  
type. Unless the input buffer really has no sense to be not RGBA (like  
for vector blur, currently only accepting the appropriate buffers as  
coming from render).

-Ton-

On 15 Jan, 2007, at 2:16, mindrones wrote:

> Hi Bob,
>
> I'm aware this is BCon-3, just wandering if it's intentional that  
> images from
> RGB to BW node can't be an input in the Luma keyer (the same would  
> apply to
> alpha channels, mattes and Z, assuming them as greyscale images).
>
> Many thanks,
> Luca
>
>
> 	
>
> 	
> 		
> ___________________________________
> Vinci i biglietti per FIFA World Cup in Germania!
> yahoo.it/concorso_messenger
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>
>
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton at blender.org  
http://www.blender.org