[Bf-committers] Blender 2.43 RC1

[Campbell Barton]

Peter Schlaile wrote:
> Hi,
> 
>>> #define VARSTRUCT_NAMEMAX 16
>>>
>>> ?
>> Dear Peter, I confirm you that with my patch but lowering string size
>> again to 16 would work without overrun while importing the obj file that
>> I cited above.
> 
> OK. Commited to CVS. (I rewrote it a little bit, but my changes are
> only of cosmetic nature (hopefully). Please test!)
> 
> http://projects.blender.org/pipermail/bf-blender-cvs/2007-January/008888.html
> 
>> In the case you are interested, also one of the
>> the offending strings (I'm not sure there weren't others) was:
>>
>> "Split by Material"
>>
>> in the file release/scripts/import_obj.py at line 730,
>> which is 17 character long (plus 1 for end string terminator,
>> so 18). Of course with my patch in the menu it's truncated to
>> "Split by Materi" (maybe a better string could be "Split by Mater."),
>> but at least the string buffer remain protected without overflow.
> 
> Campbell, could you take a look?
> 
> Greetings,
> Peter
> 
Long strings are now supported in pupBlock because Im using the tooltip 
to store the label, this wont effect anything outside clever numbuts.