[Bf-committers] Sculpt commit issue...

[Nicholas Bishop]

Hi,

> For example, what the set_sculpt_object() is supposed to do and why it
> was added is nowhere to find...
This function was intended to provide a single location to create data
specific to sculptmode meshes. Exactly what this data was has changed
as the code evolved, currently it's extra connectivity information
(the vertex_users array) and temporarily applying a shape key.
Sculptmode is like edit mode in that it edits the vertices for a
specific shape key, rather than using the interpolated vertices of a
particular frame. The idea with keys is that anytime the key is
changed, apply the key to the mesh with key_to_mesh. If there's
already a key applied to the mesh, then any sculpting that has
happened should be applied to the old key before switching to the new
one.

> It also seems you temporary disabled shape keys for sculpt, so this
> code can go entirely?
shapekeys+sculptmode is only disabled if multires is enabled. If at
all possible I'd like to keep plain shapekeys+sculptmode (without
multires) enabled for release, since it does provide very useful
functionality.

Do you have any thoughts on a better way to handle set_sculpt_object?
I agree that calling it all over the place is not the best solution
(plus it's apparently causing breakage) but I need some way to be sure
that that information is always created for the current sculpting mesh
and deleted when that mesh is no longer being sculpted.

-Nicholas