[Bf-committers] Broken binary plugins

[Campbell Barton]

Hi, didnt expect the VarStruct would mess up anything.
The reason I added it is that its used for clever_numbets (pupBlock in 
python) and some descriptive labels was cut down to use about half of 
space available.

Looks like this opens a can of worms so it can be changed back of others 
agree its a good idea... if thats the case Ill look at making 
clever_numbuts do text some other way.

- Cam


Peter Schlaile wrote:
> Hi,
> 
> the recent changes by Ton and Campbell broke binary compatibility
> of sequencer plugins (and most probably of the other binary plugins, too).
> 
> Ton's changes made ImBuf's part of the linkable list system and therefore
> added fields at the beginning of the structure. This can't be easily done
> in another way and is badly needed for the flipbook system, if I
> understood it correctly.
> 
> For the plugin system, that can be worked around with a version bump and
> a little pointer hackery. (See patch below, that does it for sequencer
> plugins)
> 
> Campbell's patch seems more of cosmetic nature. It changes
> VarStruct and enlarges the name-field from 16 to 32 bytes. (And that even
> inconsistently, since it only does so in blenkernel and not in the
> plugin interface.)
> 
> Since the later is cosmetic, I suggest to revert it. (Hacking around it
> means also copying the VarStruct structure around or do some nasty hackery
> in the GUI code.)
> 
> The following patch makes sequencer plugins work again:
> http://peter.schlaile.de/seq_plugin_fix.diff
> 
> but is still open for discussion.
> 
> Greetings,
> Peter
> 
> P.S.: Campbell's patch can be found here:
> http://projects.blender.org/pipermail/bf-blender-cvs/2006-December/008720.html
> 
> ----
> Peter Schlaile <peter at schlaile.de> [Telefon: 0721 - 130277]
> 
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
> 


-- 
Campbell J Barton

133 Hope Street
Geelong West, Victoria 3218 Australia

URL:    http://www.metavr.com
e-mail: cbarton at metavr.com
phone: AU (03) 5229 0241