[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [13070] branches/blender2.5/blender/intern /ghost/intern/GHOST_WindowX11.cpp: Fix bad argument order to XTranslateCoordinates.

Diego Hernan Borghetti bdiego at gmail.com
Mon Dec 31 07:33:45 CET 2007


On Mon, 31 Dec 2007, Diego Borghetti wrote:

> Revision: 13070
>          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=13070
> Author:   bdiego
> Date:     2007-12-31 07:19:04 +0100 (Mon, 31 Dec 2007)
>
> Log Message:
> -----------
> Fix bad argument order to XTranslateCoordinates.
>
> Take me a long time catch this :/ and i really don't know how this
> work before, because clientToScreen always return bad values.

Also found others errors (win->x/y != real window position), i have
some of this fix, but need investigate a little more.

My current TODO (for tomorrow):
 	- fix the problem with coordinates system.
 	- fix the ConfigureEvent handler.
 	- fix get/setState

>
> Modified Paths:
> --------------
>    branches/blender2.5/blender/intern/ghost/intern/GHOST_WindowX11.cpp
>
> Modified: branches/blender2.5/blender/intern/ghost/intern/GHOST_WindowX11.cpp
> ===================================================================
> --- branches/blender2.5/blender/intern/ghost/intern/GHOST_WindowX11.cpp	2007-12-30 23:58:59 UTC (rev 13069)
> +++ branches/blender2.5/blender/intern/ghost/intern/GHOST_WindowX11.cpp	2007-12-31 06:19:04 UTC (rev 13070)
> @@ -565,15 +565,15 @@
> 	GHOST_TInt32& outX,
> 	GHOST_TInt32& outY
> ) const {
> -	// not sure about this one!
> +	// Now, this is correct!
>
> 	int ax,ay;
> 	Window temp;
>
> 	XTranslateCoordinates(
> 			m_display,
> +			m_window,
> 			RootWindow(m_display, m_visual->screen),
> -			m_window,
> 			inX,
> 			inY,
> 			&ax,
>
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>

-- 
 			Diego


More information about the Bf-committers mailing list