[Bf-committers] cygwin link error: solved

Tanner Jotblad tannerjotblad at gmail.com
Sat Dec 8 01:05:48 CET 2007


Hi, yet more cygwin problems, this one was trying to link to the non 
FREE_WINDOWS iconv.
The check for FREE_WINDOWS was missing a ')', and it was looking in 
NAN_GETTEXT instead of NAN_ICONV.
Here's the patch, once again, if this could be tested and committed, I'd 
be happy:

Index: source/nan_definitions.mk
===================================================================
--- source/nan_definitions.mk    (revision 12822)
+++ source/nan_definitions.mk    (working copy)
@@ -540,8 +540,8 @@
     export NAN_ZLIB ?= $(LCGDIR)/zlib
     export NAN_NSPR ?= $(LCGDIR)/nspr
     export NAN_GETTEXT ?= $(LCGDIR)/gettext
-    ifeq ($FREE_WINDOWS), true)
-       export NAN_GETTEXT_LIB ?= $(NAN_GETTEXT)/lib/freegettext.a 
$(NAN_GETTEXT)/lib/freeiconv.a
+    ifeq ($(FREE_WINDOWS), true)
+       export NAN_GETTEXT_LIB ?= $(NAN_GETTEXT)/lib/freegettext.a 
$(NAN_ICONV)/lib/freeiconv.a
     else
        export NAN_GETTEXT_LIB ?= $(NAN_GETTEXT)/lib/gnu_gettext.lib 
$(NAN_GETTEXT)/lib/iconv.lib
     endif



More information about the Bf-committers mailing list