[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/blenkernel BKE_brush.h blender/source/blender/blenkernel/intern brush.c blender/source/blender/makesdna DNA_brush_types.h blender/source/blender/src buttons_editing.c drawimage.c imagepaint.c vpaint.c

[bjornmose at gmx.net]

Hi Brecht,

you know, i love clean code.
However removing

painter->lastpaintpos[0]= pos[0];                    painter->lastpaintpos[1]= pos[1];   

from 
brush_painter_paint()

seems to cause the smear brush to lift up a wrong initial pattern.
 
Maybe the startpaintpos[] member could be used for that purpose too?

Cheers BM



-------- Original-Nachricht --------
Datum: Sun, 24 Sep 2006 21:29:25 +0200 (CEST)
Von: Brecht Van Lommel <brechtvanlommel at pandora.be>
An: bf-blender-cvs at blender.org
Betreff: [Bf-blender-cvs] CVS commit: blender/source/blender/blenkernel BKE_brush.h blender/source/blender/blenkernel/intern brush.c blender/source/blender/makesdna DNA_brush_types.h blender/source/blender/src buttons_editing.c drawimage.c imagepaint.c vpaint.c

> blendix (Brecht Van Lommel) 2006/09/24 21:29:25 CEST
> 
>   Modified files:
>     blender/source/blender/blenkernel BKE_brush.h 
>     blender/source/blender/blenkernel/intern brush.c 
>     blender/source/blender/makesdna DNA_brush_types.h 
>     blender/source/blender/src buttons_editing.c drawimage.c 
>                                imagepaint.c vpaint.c 
>   
>   Log:
>   Basic pressure sensitivity support in imagepaint, for opacity, size,
>   falloff and spacing. Click the button labeled "P" next to the sliders.
>   Works best for opacity, other options can give poor quality strokes in
>   some cases. Also performance needs to be improved.
>   
>   Remember, works only on X11 and Mac, no Windows support for tablets yet.
>   
>   Revision  Changes    Path
>   1.4       +2 -2      blender/source/blender/blenkernel/BKE_brush.h
>    
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/blenkernel/BKE_brush.h.diff?r1=1.3&r2=1.4&cvsroot=bf-blender>
>   1.6       +55 -13    blender/source/blender/blenkernel/intern/brush.c
>    
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/blenkernel/intern/brush.c.diff?r1=1.5&r2=1.6&cvsroot=bf-blender>
>   1.6       +8 -4      blender/source/blender/makesdna/DNA_brush_types.h
>    
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/makesdna/DNA_brush_types.h.diff?r1=1.5&r2=1.6&cvsroot=bf-blender>
>   1.280     +9 -5      blender/source/blender/src/buttons_editing.c
>    
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/buttons_editing.c.diff?r1=1.279&r2=1.280&cvsroot=bf-blender>
>   1.78      +9 -5      blender/source/blender/src/drawimage.c
>    
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/drawimage.c.diff?r1=1.77&r2=1.78&cvsroot=bf-blender>
>   1.12      +31 -20    blender/source/blender/src/imagepaint.c
>    
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/imagepaint.c.diff?r1=1.11&r2=1.12&cvsroot=bf-blender>
>   1.71      +4 -1      blender/source/blender/src/vpaint.c
>    
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/vpaint.c.diff?r1=1.70&r2=1.71&cvsroot=bf-blender>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-blender-cvs

-- 
NEU: GMX DSL Sofort-Start-Set - blitzschnell ins Internet!
Echte DSL-Flatrate ab 0,- Euro* http://www.gmx.net/de/go/dsl