[Bf-committers] OSX intel Libs

[Hans Lambermont]

trip somewhere wrote:

>  ifeq ($(OS),darwin)
> 
>    export ID = $(shell whoami)
>    export HOST = $(shell hostname -s)
> 
>    export PY_FRAMEWORK	= 1
>    ifdef PY_FRAMEWORK
>       export NAN_PYTHON ?= /Library/Frameworks/Python.framework/Versions/2.5/include/python2.5
>       export NAN_PYTHON_VERSION ?= 2.3

The above two lines are in conflict :
NAN_PYTHON talks about 2.5, NAN_PYTHON_VERSION talks about 2.3 .

This will cause problems, but probably not the ones you've mailed so far ;-)

>       export NAN_PYTHON_BINARY ?= $(NAN_PYTHON)/bin/python$(NAN_PYTHON_VERSION)
>    else
>       export NAN_PYTHON ?= /sw
>       export NAN_PYTHON_VERSION ?= 2.5
>       export NAN_PYTHON_BINARY ?= $(NAN_PYTHON)/bin/python$(NAN_PYTHON_VERSION)
>    endif

Furthermore the when a version number is part of a path, then the above
should have been rewritten as :

export NAN_PYTHON ?= /Library/Frameworks/Python.framework/Versions/$(NAN_PYTHON_VERSION)/include/python$(NAN_PYTHON_VERSION)

Just like the NAN_PYTHON_BINARY already is.

regards,
   Hans Lambermont