[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/blenkernel/intern customdata.c blender/source/blender/python/api2_2x Mesh.c

[Campbell Barton]

IMHO previous functionality wasnt correct, best document the change and 
make sure scripts are altered for it.

Brecht Van Lommel wrote:
>
> Hi,
>
> The comment in that function is wrong, forgot to update it, shouldn't 
> say anything about texture faces. I think the problem is that colors 
> are now stored separate from tfaces, so e.g. Mesh.faceUV doesn't imply 
> anymore that colors exist. Not sure what the best solution is for 
> that. Should compatibility be dropped, or should Mesh.faceUV still 
> check for or create both tfaces and colors?
>
> Brecht.
>
> Campbell Barton wrote:
>> Hi Brecht, at the moment Im getting this error popping up in various 
>> scripts
>> ValueError: face has no vertex colors
>>
>>
>> Im using Mesh not NMesh and the error is here
>>
>> static PyObject *MFace_getCol( BPy_MFace * self )
>> {
>>    PyObject *attr;
>>    int length, i;
>>    MCol * mcol;
>>
>>    /* if there's no mesh color vectors or texture faces, nothing to 
>> do */
>>
>>    if( !self->mesh->mcol )
>>        return EXPP_ReturnPyObjError( PyExc_ValueError,
>>                "face has no vertex colors" );
>>
>>
>> - Shouldnt per face colors still be supported?
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>


-- 
Campbell J Barton

133 Hope Street
Geelong West, Victoria 3218 Australia

URL:    http://www.metavr.com
e-mail: cbarton at metavr.com
phone: AU (03) 5229 0241