[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/src transform_generics.c transform_manipulator.c

[Campbell Barton]

For some reason at the time I saw this as EditMode functionality, and it 
was discussed at length with Briggs, who was doing some development that 
the transform manipulator depended on.

Transform code added was fairly minimal but will think of the files Im 
touching as well as the type of feature next time.

transform_manipulator.c:235

            /* USE LAST SELECTE WITH ACTIVE */
            if (G.vd->around==V3D_ACTIVE && em->selected.last) {
                EM_editselection_center(vec, em->selected.last);
                calc_tw_center(vec);
                totsel= 1;
                if (v3d->twmode == V3D_MANIP_NORMAL) {
                    EM_editselection_normal(normal, em->selected.last);
                    EM_editselection_plane(plane, em->selected.last);
                } /* NORMAL OPERATION */
            } else {


transform_generics.c:731

        /* EDIT MODE ACTIVE FACE */
        if (G.obedit && G.obedit->type == OB_MESH && 
G.editMesh->selected.last) {
            EM_editselection_center(t->center, G.editMesh->selected.last);
            break;
        }

- Cam



Martin Poirier wrote:
> Please, when you commit code in places where you are
> not the maintainer, at least add some technical change
> notes to the commit log (at best, go through the patch
> tracker, of course).
>
> It's harder to maintain code which I haven't done,
> just imagine what happens when people drop some in
> without warning and without docs.
>
> thanks
> Martin
> PS: This doesn't apply only to Campbell, of course.
>
> --- Campbell Barton <cbarton at metavr.com> wrote:
>
>   
>> campbellbarton (Campbell Barton) 2006/03/27 07:28:36
>> CEST
>>
>>   Modified files:
>>     blender/source/blender/src transform_generics.c 
>>                               
>> transform_manipulator.c 
>>   
>>   Log:
>>   Added rotate about centre for active
>> Vert/Edge/Face in mesh editmode. also works for
>> getting the V/E/F normal. Means we can now rotate
>> about the last selected edge.
>>   
>>   Revision  Changes    Path
>>   1.84      +26 -2    
>> blender/source/blender/src/transform_generics.c
>>    
>>
>>     
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/transform_generics.c.diff?r1=1.83&r2=1.84&cvsroot=bf-blender>
>   
>>   1.57      +115 -27  
>> blender/source/blender/src/transform_manipulator.c
>>    
>>
>>     
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/transform_manipulator.c.diff?r1=1.56&r2=1.57&cvsroot=bf-blender>
>   
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at projects.blender.org
>>
>>     
> http://projects.blender.org/mailman/listinfo/bf-blender-cvs
>   
>
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around 
> http://mail.yahoo.com 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>
>   


-- 
Campbell J Barton

133 Hope Street
Geelong West, Victoria 3218 Australia

URL:    http://www.metavr.com
e-mail: cbarton at metavr.com
phone: AU (03) 5229 0241