[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/src sequence.c

[Ton Roosendaal]

Hi,

Depends on what you mean with 'excessive'. Forcing lines to always fit  
within 80 chars (and especially when you have tab size on 8 spaces)  
will too quickly result in very short lines of code. This for example;

		se->ibuf= IMB_loadiffname(name,
         IB_rect);

Nevertheless; it's also based on personal style and past experience.  
Most important for now is try to keep code consistant at least per  
module or file.
The coding guideline page needs update too... the 80 chars convention  
is quite narrow in many cases, especially if you decide to use longer  
variable names for readability.

Will come back to it later... stressy days here. :)

-Ton-




On 15 Mar, 2006, at 0:41, Ben Batt wrote:

> On 3/15/06, Toni Alatalo <antont at kyperjokki.fi> wrote:
>> On Tuesday 14 March 2006 10:54, Ton Roosendaal wrote:
>>>   Schlaile; do you have a weird texteditor setting or so? It breaks  
>>> up
>>>   function calls in a very strange way, with each argument of a call
>>>   on a new line. That's not code that way, that's movie credits! :)
>>
>> i think it looked like nice code,
>> is nice to have them blocked
>> .. and not awfully long lines.
>>
>
> Yes, I too prefer to wrap function calls if they're getting too long
> rather than have
> excessively long lines. Is this a big no-no?
>
> Artificer
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton at blender.org  
http://www.blender.org