[Bf-committers] Re: Do release scripts automatically copy the logo.png from "blender\release\scripts\bpymodules\colladaImEx" ?

pspcontest at erwincoumans.com pspcontest at erwincoumans.com
Wed Jun 14 22:38:38 CEST 2006


Number one is that Blender benefits greatly from COLLADA 1.4 export/import. 

Don't use the lack of documentation as an excuse for 'dev review'. This is 
just a small incident, which is already being resolved. That is what this 
committers mailing list is for. 

My original questions was already answered, and we are working on this 
Python 2.3 compatibility. 

D.J. Capelis: calling this area of the tree 'slightly chaotic area of the 
tree' is annoying and upsetting for people who are doing hard work. 

Thanks,
Erwin 

 


D.J. Capelis writes: 

> As much as we normally work on a nice informal basis most of the time,
> perhaps it would be a good time to establish a formal checklist for all
> scripts being committed and have a small review process before scripts
> are checked in which includes a signoff by two devs, the one who is
> going to commit the script and a (different) dev from the py team.  Then
> just make a note on CVS checkin that said who reviewed it.  A little bit
> more formal than it is now... but will probably save us some trouble
> down the road and ensure things like this get caught earlier. 
> 
> For people outside the py team who need additional reviews for platform
> specific issues (like on windows, making sure that paths stored in
> strings don't become escape characters or whatever other problems crop
> up...) or other common pitfalls we notice can just add it to the
> checklist and it would become part of the review process. 
> 
> It seems like a good idea to ensure some consistency in what seems to be
> turning into a slightly chaotic area of the tree.  I imagine
> contributors would find a nice point-by-point list of things we
> particularly care about before committing handy as well.  Does this seem
> reasonable to folks? 
> 
> On Wed, 2006-06-14 at 09:24 -0800, Tom M wrote:
>> This is partially my fault, I failed to mention to the Collada
>> developer the 2.3 compatibility requirement, and didn't mention it to
>> Erwin when he asked if it was ok to commit it.  (I was probably
>> 'assuming' they knew, or more likely it just didn't occur to me to
>> mention it...) 
>> 
>> As mentioned earlier part of the problem is that the two platforms
>> where most of the script development takes place almost never have
>> python 2.4 builds done.  Another issue is that the 2.3 compatability
>> requirement probably isn't too widely known beyond the core team (and
>> even then we tend to have things slip - ie cambos script that required
>> sets...). 
>> 
>> So my apologies for the problems my lapse has caused. 
>> 
>> LetterRip
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at projects.blender.org
>> http://projects.blender.org/mailman/listinfo/bf-committers 
>> 
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
 



More information about the Bf-committers mailing list