[Bf-committers] Python: globals and pose bones, et al.
Chris Want
cwant at ualberta.ca
Mon Jan 16 05:41:20 CET 2006
Hi,
There are a number of cases in the python code of
globals being defined in header files, then the header
is included in multiple files. This is bad, since it
means the global variables are multiply defined. An
example of this is PoseBonesDict_Type (and others),
defined in Pose.h, which is then included in Pose.c
and Object.c. What should happen instead, is that
PoseBonesDict_Type (and others) should be defined
in Pose.c and declared as 'extern' in Pose.h. Some
other symbols that have been declared this way
(perhaps not all of them though):
BonesDict_Type
Action_Type
PoseBonesDict_Type
EditBone_Type
Armature_Type
BonesDict_Type
Somebody should probably correct this.
Chris
More information about the Bf-committers
mailing list