[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/include BIF_space.h blender/source/blender/python/api2_2x Object.c blender/source/blender/python/api2_2x/doc Object.py blender/source/blender/src editarmature.c editcurve.c header_view3d.c meshtools.c space.c

[Stephen Swaney]

On Fri, Dec 30, 2005 at 03:17:16PM +0100, Campbell Barton wrote:
> campbellbarton (Campbell Barton) 2005/12/30 15:17:16 CET
>
>   Log:
>   Added a python hook to Joining objects
>   Object.Join()
>   
>   Seperated the join calls from space.c and view3dmenu into join_menu() in space.c, like the select_group_menu(),
>   okee's from join_curve, join_mesh.. etc are in join_menu() so python can call them without UI menu's in the way.
>   this is also a bit neater since there were 2 places that were doing what join_menu() does now.


A couple thoughts:

In Object.c in the M_Object_Join() method, before you use ob after 
  Object *ob= OBACT;
you might want to check for ob being nonzero 
since OBACT is a macro that can return O.


Since the scripter cannot tell of Object.Join() did anything,
you might want to return the number of objects joined instead
of None.

-- 
Stephen Swaney			
sswaney at centurytel.net