[Bf-committers] Fwd: [Bf-blender-cvs] CVS commit:
blender/source/blender/blenlib BLI_editVert.h
blender/source/blender/include BIF_editmesh.h
blender/source/blender/src edit.c editmesh.c editmesh_lib.c
editmesh_mods.c editmesh_tools.c header_view3d.c
Ton Roosendaal
ton at blender.org
Tue Feb 14 13:16:05 CET 2006
Hi Geoffrey,
First commit! Congrats, but there's some issues you have to look at;
- As told before, you need to subscribe to the bf-blender-cvs mailing
list.
http://projects.blender.org/mailman/listinfo/bf-blender-cvs
Otherwise your commit mails are not accepted.
- The cvs log you write is far too short. When you commit so much code,
you really have to include detailed explanation. A link to our wiki,
blender.org cms or a private page is fine too. But then still add
sufficient information for cvs logs to be an interesting read.
Also bug fixes can't be accepted with a remark "fix for #2123" only. :)
- In your code are several cases of double tabs or missing tabs. Like
the new EM_convertsel() function.
- You really have to watch warnings on compile time... functions used
externally require a prototype in a header
- Follow coding style of code you work in. Like no new-line for a {.
- It's confusing to use local variable names with capitals, especially
when function names use a similar construction... like variable
edgeCollection vs function freeCollections().
The simple rule is to only use capitals in global variables and in
exported functions.
- You added an Undo push in a general EditMesh lib call... whilst this
call is used all over in tools that do own undo pushes. the
editmesh_lib.c function is supposed to be *fully* UI free. No menus, no
undo pushes, etc.
- I am very unsure about the implementation of build_edgecollection(),
but the call to BLI_linklist_append() is definitely wrong... it needs a
pointer-pointer... how can this work?
- the LinkNode struct was not meant to be exported outside blenlib/. I
know it is used within the game engine hack in space.c... but that's
for now the only exception.
I think your work is very welcome though, hope you can accept being
criticized a bit now :)
-Ton-
Begin forwarded message:
> From: Geoffrey Bantle <hairbat at yahoo.com>
> Date: 13 February, 2006 23:49:47 GMT+01:00
> To: bf-blender-cvs at blender.org
> Subject: [Bf-blender-cvs] CVS commit: blender/source/blender/blenlib
> BLI_editVert.h blender/source/blender/include BIF_editmesh.h
> blender/source/blender/src edit.c editmesh.c editmesh_lib.c
> editmesh_mods.c editmesh_tools.c header_view3d.c
> Reply-To: bf-committers at blender.org
>
> briggs (Geoffrey Bantle) 2006/02/13 23:49:47 CET
>
> Modified files:
> blender/source/blender/blenlib BLI_editVert.h
>
> source/blender/blenlib/BLI_editVert.h
>
> source/blender/include/BIF_editmesh.h
> source/blender/src/edit.c
> source/blender/src/editmesh.c
> source/blender/src/editmesh_lib.c
> source/blender/src/editmesh_mods.c
> source/blender/src/editmesh_tools.c
> source/blender/src/header_view3d.c
> Log: Commit of the 'upgraded
> merge tools' (Patch #3345) and
> 'inclusive selection mode
> conversion' (Patch #3768).
> blender/source/blender/include BIF_editmesh.h
>
> source/blender/blenlib/BLI_editVert.h
>
> source/blender/include/BIF_editmesh.h
> source/blender/src/edit.c
> source/blender/src/editmesh.c
> source/blender/src/editmesh_lib.c
> source/blender/src/editmesh_mods.c
> source/blender/src/editmesh_tools.c
> source/blender/src/header_view3d.c
> Log: Commit of the 'upgraded
> merge tools' (Patch #3345) and
> 'inclusive selection mode
> conversion' (Patch #3768).
> blender/source/blender/src edit.c editmesh.c editmesh_lib.c
> editmesh_mods.c editmesh_tools.c
> header_view3d.c
> source/blender/blenlib/BLI_editVert.h
> source/blender/include/BIF_editmesh.h
> source/blender/src/edit.c
> source/blender/src/editmesh.c
> source/blender/src/editmesh_lib.c
> source/blender/src/editmesh_mods.c
> source/blender/src/editmesh_tools.c
> source/blender/src/header_view3d.c
> Log: Commit of the 'upgraded merge
> tools' (Patch #3345) and 'inclusive
> selection mode conversion' (Patch
> #3768).
>
> Log:
>
>
> Revision Changes Path
> 1.23 +4 -1 blender/source/blender/blenlib/BLI_editVert.h
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/blenlib/BLI_editVert.h.diff?r1=1.22&r2=1.23&cvsroot=bf-
> blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> 1.55 +5 -1 blender/source/blender/include/BIF_editmesh.h
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/include/BIF_editmesh.h.diff?r1=1.54&r2=1.55&cvsroot=bf-
> blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> 1.83 +63 -15 blender/source/blender/src/edit.c
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/src/edit.c.diff?r1=1.82&r2=1.83&cvsroot=bf-blender>
> 1.169 +46 -3 blender/source/blender/src/editmesh.c
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/src/editmesh.c.diff?r1=1.168&r2=1.169&cvsroot=bf-blender>
> 1.49 +65 -0 blender/source/blender/src/editmesh_lib.c
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/src/editmesh_lib.c.diff?r1=1.48&r2=1.49&cvsroot=bf-blender>
> 1.79 +17 -3 blender/source/blender/src/editmesh_mods.c
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/src/editmesh_mods.c.diff?r1=1.78&r2=1.79&cvsroot=bf-blender>
> 1.136 +379 -0 blender/source/blender/src/editmesh_tools.c
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/src/editmesh_tools.c.diff?r1=1.135&r2=1.136&cvsroot=bf-
> blender>
> 1.155 +14 -6 blender/source/blender/src/header_view3d.c
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/
> blender/src/header_view3d.c.diff?r1=1.154&r2=1.155&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
>
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/.diff?r1=bf-blender.
> -1&r2=&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> No revision
>
> <http://projects.blender.org/viewcvs/viewcvs.cgi/revision.diff?r1=bf-
> blender.-1&r2=No&cvsroot=bf-blender>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-blender-cvs
>
>
------------------------------------------------------------------------
--
Ton Roosendaal Blender Foundation ton at blender.org
http://www.blender.org
More information about the Bf-committers
mailing list