[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/blenloader/intern readfile.c blender/source/blender/makesdna DNA_mesh_types.h DNA_meshdata_types.h blender/source/blender/src editmesh.c editmesh_lib.c

[Campbell Barton]

The new selection stores the order of selection, its not meant to store 
the entire selection at any time.
Rather a way to store first/last.
Its realy usefull for Manipulator - "Rotate about active" - which is 
very useful, removing the need to use the snap menu in many cases. since 
you can rotate about the last selected edge.

it could be used to make a scanfilled fgon by the order the points are 
selected for eg.
as for storing them in the DNA- its just so toggling editmode dosent 
flush the data but I cant speak for its implimentation.
- Cam

Ton Roosendaal wrote:
> Hi Geoffrey,
>
> I just noticed this code now, because of a crash report... I really 
> think this should need a review first, because;
> - Selections were already stored
> - This method, storing selections separately, makes the whole editmesh 
> maintenance even more complex as it was
>
> If there were issues with selection storage, what cases is that?
>
> -Ton-
>
>
> On 3 Apr, 2006, at 21:02, Geoffrey Bantle wrote:
>
>> briggs (Geoffrey  Bantle) 2006/04/03 21:02:22 CEST
>>
>>   Modified files:
>>     blender/source/blender/blenloader/intern readfile.c
>>     blender/source/blender/makesdna DNA_mesh_types.h
>>                                     DNA_meshdata_types.h
>>     blender/source/blender/src editmesh.c editmesh_lib.c
>>
>>   Log:
>>   -> Stored Selections in Mesh DNA
>>
>>   Stored selections now get saved to mesh library blocks as direct data.
>>   The idea that stored selections are 'erased' when leaving editmode and
>>   switching objects is pretty mysterious for the user. Note that 
>> currently
>>   the mselect array in a mesh is not written to file.  Not sure whether
>>   to change this or not.
>>
>>   Revision  Changes    Path
>>   1.252     +2 -1      
>> blender/source/blender/blenloader/intern/readfile.c
>>     
>> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/blenloader/intern/readfile.c.diff?r1=1.251&r2=1.252&cvsroot=bf-blender> 
>>
>>   1.31      +4 -3      blender/source/blender/makesdna/DNA_mesh_types.h
>>     
>> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/makesdna/DNA_mesh_types.h.diff?r1=1.30&r2=1.31&cvsroot=bf-blender> 
>>
>>   1.20      +9 -1      
>> blender/source/blender/makesdna/DNA_meshdata_types.h
>>     
>> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/makesdna/DNA_meshdata_types.h.diff?r1=1.19&r2=1.20&cvsroot=bf-blender> 
>>
>>   1.173     +57 -5     blender/source/blender/src/editmesh.c
>>     
>> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/editmesh.c.diff?r1=1.172&r2=1.173&cvsroot=bf-blender> 
>>
>>   1.58      +0 -7      blender/source/blender/src/editmesh_lib.c
>>     
>> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/src/editmesh_lib.c.diff?r1=1.57&r2=1.58&cvsroot=bf-blender> 
>>
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at projects.blender.org
>> http://projects.blender.org/mailman/listinfo/bf-blender-cvs
>>
>>
> -------------------------------------------------------------------------- 
>
> Ton Roosendaal  Blender Foundation ton at blender.org http://www.blender.org
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>


-- 
Campbell J Barton

133 Hope Street
Geelong West, Victoria 3218 Australia

URL:    http://www.metavr.com
e-mail: cbarton at metavr.com
phone: AU (03) 5229 0241