[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/src editobject.c

[Ton Roosendaal]

Hi Ken,

I don't know what OS you compile in, but checking for warnings is very  
important!
gcc gave me this:

 > editobject.c: In function `docentre':
 > editobject.c:1584: warning: `cu' might be used uninitialized in this  
function

Which was pointing at a serious problem in the code... I do realize the  
docentre function is a very bad construct of itself, mixing up editmode  
and objectmode in a confusing way.

Anyhoo; committed a proper initialize for this cu variable.

-Ton-


On 24 Mar, 2006, at 21:39, Ken Hughes wrote:

> khughes (Ken Hughes) 2006/03/24 21:39:39 CET
>
>   Modified files:
>     blender/source/blender/src editobject.c
>
>   Log:
>   Bugfix #3772: Allows "Center Cursor" for 3D curves to modify the  
> curve
>   center's Z location.  An eons-old comment in the code said:
>
>   /* Curves need to be 2d, never offset in
>    * Z. Is a somewhat arbitrary restriction,
>    * would probably be nice to remove. */
>
>   I couldn't find any other reason for the restriction other than 2D  
> curves
>   limit the point's Z component to 0, so added a check to only forve  
> the
>   center Z to 0 when the curve is 2D.  If there are other reasons for  
> the
>   restriction, then this commit may need to be rolled back.
>
>   Revision  Changes    Path
>   1.299     +5 -7      blender/source/blender/src/editobject.c
>      
> <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/ 
> blender/src/editobject.c.diff?r1=1.298&r2=1.299&cvsroot=bf-blender>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-blender-cvs
>
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton at blender.org  
http://www.blender.org