[Bf-committers] Compile warnings

[Brecht Van Lommel]

Hi,

Some notes/questions:
- The tool shape drawing forces the whole image window to redraw on
   every mouse move. This makes it really slow when working with a big
   image here. I don't think this is acceptable, and providing a user setting
   to disable it doesn't really solve the issue.. . Since the tool shape is a
   XOR circle, it should be possible to draw over it, and draw a new circle
   without having to redraw the whole window. But that would require
   frontbuffer drawing .. . It might be best to disable this until it is coded
   better.
- Are the Aux AB1 and Aux AB2 brushes really needed? I find it confusing.
   In my opinion, the tools should just all share color, size, etc.

Brecht.

Brecht Van Lommel wrote:
> 
> Hi,
> 
> This is sort of my fault. I'll clean the code up and check on do a better
> review of it...
> 
> Brecht.
> 
> bjornmose wrote:
> 
>> Ton Roosendaal wrote:
>>
>>> - ImagePaint
>>> The code added in headerimage.c is very messy. At least follow a bit  
>>> the C convention as used in the rest of the file. Further I don't  
>>> advise to use the old clever_numbut code anymore...
>>> then there's a global array written with capitals (UVTEXTTOOL_DATA),  
>>> and I really don't get why all these globals are needed in  
>>> imagepaint.c...
>>> In space.c you use calls from imagepaint.c without prototypes.
>>>
>>> This could have used a good code review before added, and poking 
>>> people  who like to design button panels. Seems like much wanted 
>>> functionality  yes, but worth checking on a good integration to make 
>>> it future proof.  :)
>>
>>
>> Hi ton,
>> totally argree,
>> This is why put 2D UV painting ( aka imagepaint )to patch tracker first.
>> I even pointed out some weak points you're complaining about now.
>> Especially global vars.
>> .. 
>> https://projects.blender.org/tracker/index.php?func=detail&aid=2866&group_id=9&atid=127 
>>
>> ..
>> But i never got any usefull feedback on how to do it better.
>> Asking brecht (don't want to blame him at all) resulted in 'commit and 
>> see' so .. i don't mind to roll back the whole thing and do it right.
>> Only i don't have a faint idea what is supposed to be *right*.
>> /* beeing scientist and  C++ coder who likes standard template libs 
>> (STL) makes me quilty 'per se' and i apologize for that. */
>>
>> about headerimage.c
>> is the *mess* declaring local vars ? ( easy to fix )
>>
>> about use of clever_numbut code .. never really liked it .. but how to 
>> get 'user input' for some numbers needed for creation process ( 
>> preferably remembering last input ) ...
>>
>> and so on
>> hmm .. but if someone would have looked at the patch ..
>> .. sigh ..
>> BM
>>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
> 
>