[Bf-committers] simple segfault fix in Blender.

[Ton Roosendaal]

Hi,

Confirmed, although it was for me on line 2310... :)

Can't really say this 'Join' tool makes a nice result though... it's  
code unknown to me, written in NaN days. Can be much better, but I'll  
commit at least the line to prevent it crashing.

Thanks,

-Ton-

On 5 May, 2005, at 6:54, Campbell Barton wrote:

> Hi, At the moment the join_triangles():2336 function in  
> editmesh_tools.c dosent account for givequadverts():2017, assigning  
> NULL to v3 and v4. (See line 2105)
>
> This makes a realy stupid segfault.
> Try getting the monky.
> Ctrl+T
> Jkey
> Ctrl+T
> Jkey ...> Segfault.
>
>
> To fix this, add this line in editmesh_tools.c:2391
> if (v3 != NULL && v4 != NULL) {
>
> ... This checks that givequadverts() hasnt set v3 ir v4 as null.
>
> - Cam
>
>
> --  
> Campbell J Barton
>
> 133 Hope Street
> Geelong West, Victoria 3218 Australia
>
> URL:    http://www.metavr.com
> e-mail: cbarton at metavr.com
> phone: AU (03) 5229 0241
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton at blender.org  
http://www.blender.org