[Bf-committers] The big warning hunt patch

[Gilbert, Joseph]

@@ -507,14 +507,14 @@
 	GraphicsImportComponent		theImporter = NULL;
 
 	FSSpec	theFSSpec;
-	Str255  dst;
+//	Str255  dst; /*unused*/
 	char	theFullPath[255];


in quicktime_import.c breaks the windows compile. The variable dst is
not used on apple but is used on windows:

#ifdef __APPLE__
	err = FSPathMakeRef(theFullPath, &myRef, 0);
	err = FSGetCatalogInfo(&myRef, kFSCatInfoNone, NULL, NULL,
&theFSSpec, NULL);
#else
	CopyCStringToPascal(theFullPath, dst);
	err = FSMakeFSSpec(0, 0L, dst, &theFSSpec);
#endif

Renderconverter now imports 2 files that are from other projects so the
project files will need to add:
..\..\..\source\blender\yafray
..\..\..\sourec\blender\radiosity\extern\include 
to their compiler paths or else BL_imbuf will not compile.

Other than that everything else seems ok. 

Note that msvc7 compiler has different warnings entirely and different
warnings are ouput.


-----Original Message-----
From: bf-committers-bounces at projects.blender.org
[mailto:bf-committers-bounces at projects.blender.org] On Behalf Of
Jean-Luc Peuriere
Sent: Monday, March 07, 2005 3:19 PM
To: bf-blender developers
Subject: [Bf-committers] The big warning hunt patch

the definitive (?) patch is here :

http://projects.blender.org/tracker/index.php? 
func=detail&aid=2281&group_id=9&atid=127

Please check if all goes well, i will commit it in 48H if nobody veto  
it.

I'm down to 48 warnings on my XCode build system with the following  
flags :

-Wall -Wno-subscripts -Wmissing-prototypes for C files.
-Wall -Wno-subscripts C++ files.

other build systems may yield different results due to other options

Note that the level 2 C++ : -Wold-style-cast has been disabled in the  
makefiles as it was giving thousands of warnings which is useless.

We should find and define on each platform  an equivalent  set of  
meaningfull warnings to which each new commit should succeed, this  
would keep the code clean.

On a side note, scons way of managing the includes should be corrected,

it is bad to give 7 times the same path ;)
-- 
Jean-Luc

_______________________________________________
Bf-committers mailing list
Bf-committers at projects.blender.org
http://projects.blender.org/mailman/listinfo/bf-committers