[Bf-committers] [Fwd: [Re: [Bf-blender-cvs] CVS commit: blender/intern/moto/include MT_assert.h blender/intern/moto/intern MT_Assert.cpp]]

[Jacques Beaurain]

Also remember that the include is needed fro release builds as well
because if the following is not in a header somewhere:

#define assert(_Expression)     ((void)0)

all the places in the code where assert is used will break the build.
Should all the spots be using MT_assert? There is at least 165 of them
that doesn't, most of it in the Game Engine


On Mon, 17 Jan 2005 06:50:43 -0500, Jacques Beaurain
<jacques.beaurain at gmail.com> wrote:
> Hi Kester,
> 
> I see what you have done and it doesn't really bother me (except that
> it took me some time to get my build up yesterday). All that I am
> saying is that debug builds on windows gives the dialog box with a
> button to start debugging anyway so the code is not needed.
> 
> But the problem is as well that the header used to include assert.h
> and it does not anymore. So any code that used the assert call
> included MT_assert.h (directly or through parents) no longer had this
> include and would break
> 
> How do you test the builds? Do you do a full clean? I use the scons
> build on windows and your changes definitely broke a few things.
> 
> Cheers,
> Jacques
> 
> On Mon, 17 Jan 2005 23:37:54 +1300, Kester Maddock
> <Christopher.Maddock.1 at uni.massey.ac.nz> wrote:
> > But I tested it under Windows/VisualC++, Cygwin/Gcc 3.3.1, and Linux/Gcc
> > 3.2.2!
> >
> > There should be nothing about assert() (only MT_assert().)  I'll revert it if
> > it really bothers you...
> >
> > Kester
> >
> > On Monday 17 January 2005 07:10, Stephen Swaney wrote:
> > > On Sun, Jan 16, 2005 at 12:14:01PM -0500, Jacques Beaurain wrote:
> > > > Hi,
> > > >
> > > > This broke all kinds of things on Windows and possibly others too.
> > >
> > > All hell broke loose on linux with gcc 3.3 and scons.
> > > Lots of bitching about assert().
> >
> > --
> > 3rd Law of Computing:
> >         Anything that can go wr
> > fortune: Segmentation violation -- Core dumped
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at projects.blender.org
> > http://projects.blender.org/mailman/listinfo/bf-committers
> >
>