[Bf-committers] Minnaert diffuse shader

Jonathan Merritt j.merritt at pgrad.unimelb.edu.au
Sat Jan 8 18:57:52 CET 2005


OK - I can confirm that the issue was in rendercore.c.  So, to 
summarize, in addition to the original patch, the following changes need 
to be made:


source/blender/render/intern/source/rendercore.c:
line 1489:
+    else if(ma->diff_shader==MA_DIFF_MINNAERT) is= Minnaert_Diff(vn, 
lv, view, ma->darkness);

source/blender/blenkernel/intern/displist.c:
line 676:
    else if(ma->diff_shader==MA_DIFF_MINNAERT) is= Minnaert_Diff(nor, 
lv, shi.view, ma->darkness);

source/blender/src/buttons_shading.c:
line 2857:
    char *str1= "Diffuse Shader%t|Lambert %x0|Oren-Nayar %x1|Toon 
%x2|Minnaert %x3";


After those additions, everything seems to work.  I have made my changes 
in my local copy of tuhopuu3.  Can we take this discussion to the 
tuhopuu mailing list?  I can commit sometime tomorrow (later today) if 
there are no objections.  Then everyone can test it! :-)

Jonathan Merritt.

> I'm working on that at the moment... I think it might be missing some 
> of the render time stuff.  If you do a search for the other diffuse 
> types (MA_DIFF_ORENNAYAR for example), you can see that there's an 
> extra place (in rendercore.c) that these are used and yet 
> MA_DIFF_MINNAERT doesn't appear.
>
> However, it's getting late over here (4:31am - doh!), so I'm going to 
> bail very soon.
>
> Jonathan Merritt.
>
>> I applied the patch and made the changes to the
>>
>> else if(ma->diff_shader==MA_DIFF_TOON) is= Minnaert(nor, lv, 
>> shi.view, ma->darkness);
>>
>> to
>>
>> else if(ma->diff_shader==MA_DIFF_MINNAERT) is= Minnaert_Diff(nor, lv, 
>> shi.view, ma->darkness);
>>



More information about the Bf-committers mailing list