[Bf-committers] Minnaert diffuse shader

[Jonathan Merritt]

Hi Jorge,

Why not trial your new diffuse shading model in the recently re-spawned 
tuhopuu 3?  That would allow it some exposure to the more enthusiastic 
Blender users, not to mention more widespread testing.

It's great to see new renderer features like this, and they're sure to 
be accepted much more quickly into tuhopuu than into the mainstream 
codebase.  I've tried your patch against my local copy of tuhopuu3 and 
it appears to compile fine (Linux, gcc-3.3.4).  You should send a brief 
post to the tuhopuu developers mailing list describing your patch so 
that all the developers there are aware of it (preferably with links to 
some fancy renderings!).  Then, provided there are no objections, I'd be 
happy to commit it to tuhopuu3 on your behalf.

I had to add an entry for Minnaert to the diffuse shaders list (it 
wasn't in your patch).  Also, on line 676 in displist.c, you have:
    else if(ma->diff_shader==MA_DIFF_TOON) is= Minnaert(nor, lv, 
shi.view, ma->darkness);
should this be:
    else if(ma->diff_shader==MA_DIFF_MINNAERT) is= Minnaert(nor, lv, 
shi.view, ma->darkness);
If this is just a small typo then I'll fix it in the committed copy.

Keep up the good work! :-)

Jonathan Merritt.

PS - The tuhopuu mailing list is: tuhopuu-devel at projects.blender.org

>You can see a comparison in this link: 
>ftp://ftp.berlios.de/pub/worldspace/tmp/blender/COMPARACION.JPG 
>the 3 models have the same reflection and light 
> 
>Also you can see the shaders in this nvidia paper: 
>http://courses.dce.harvard.edu/~cscie236/papers/Surface Reflection 
>Models.pdf 
> 
>