[Bf-committers] Re: [Bf-blender-cvs] CVS commit:
blender/source/blender/src drawobject.c drawview.c
theeth at yahoo.com
Fri Apr 29 22:41:59 CEST 2005
--- Ton Roosendaal <ton at blender.org> wrote:
> Sigh... code reviews are difficult and take a lot of
> time. Just already
> looking at the first few lines;
> +#define R_REFLOCAL 1
> +#define R_REFGLOBAL 2
> +#define R_REFCURSOR 3
> +static short r_ref = 1; /* reference to
> (which radio button is
> selected) */
> +static short r_refp = 1; /* previous
> reference (for monitoring
> of r_ref ) */
> Define names starting with R_ are for render data,
> and adding globals
> for buttons? Should be the view3d flag.
That was out of my fields so I just let it there. :/
> This I dont get. A proper mapping from local to
> global is just applying
> the entire 4x4 matrix.
True, I was just accounting for size and rotation, not
offset from origin. Using the full 4x4 like you did
would probably be more useful, true.
> No that I *wanted* to review it...! Was am just
> doing a massive todo
> list, and choosed the shortest path. :)
> > Could be used to see position relative to a
> > object/referential.
> I need to think that over... my choice was to make
> 'tech draw' and the
> 'transform properties' panel in sync with a single
> setting. Lets
> postpone that.
Do you Yahoo!?
Yahoo! Small Business - Try our new resources site!
More information about the Bf-committers