[Bf-committers] Finally, a working patch

Nathan Letwory jesterking at letwory.net
Sun Oct 3 22:27:31 CEST 2004


Hi,

the patch finally applied ok, but there were problems compiling, so I
dived in after all. Now a few technical comments:

* don't introduce new variables in the middle of a function (unless it's
at the start of a statement block). Where this might be acceptable for C++
it is not for a few C compilers. So you should move EditFace *workface; to
the beginning of the function, along with the rest. Make sure you don't
start using expressions before everything necessary has been declared.
After that has been cleared up, it compiles fine.
* use the coding style:
http://www.blender3d.org/cms/Coding_Style.141.0.html to write your code
and patches. In your case, use hard-tabs instead of soft-tabs/spaces for
indentation.

I did a bit of cleaning and I have the following patch:
http://www.letwory.net/patch/individual_facesextrude.patch

Anyway, it is quite a handy one, even if there is some odd mousebehaviour.
See http://www.letwory.net/tutes/individual_faceextrude.htm for an
example. Notice how I have to move my mouse up, to extrude the face
down...

/Nathan

> Nathan Letwory wrote:
>
>>Actually attaching the patch would help also ;)
>>
>>/Nathan
>>
>>
> lol, that's so funny can't believe I forgot that.



More information about the Bf-committers mailing list