[Bf-committers] Patch- 3d view Object sel menu

[Campbell Barton]

OOps, I didnt quite explain it well- I alredy thaught about the bug 
where talking about and accounted for it.
There is a limit for the menu size

#define SEL_MENU_SIZE 22

so even if every object name length is 2x (plus other chars ) and there 
are 50 objects under the cursor, the menu will still work but only 
display 22 items.
Even this is okay because the menu cycles through the items and dosent 
always the same 22 at the top (just like RMB cycles through sel objects 
normaly)

I think that not having a menu limit is a bug in its self since a menu 
of ~50 would be unuseable for many people.
- Cam


Campbell Barton wrote:

> Okay, object names have a fixed length so I dont realy see this as 
> being a problem but I could just add some error checking that checks 
> that there is enough room before adding a string.
>
> how does that sound?
>
> Alexander Ewering wrote:
>
>> On Mon, 19 Jul 2004, Campbell Barton wrote:
>>
>>> Wheres the bug? how can I fix it?
>>> - Cam
>>
>>
>>
>> Here:
>>
>>> > +   char menuText[512] = "Select Object%t";
>>
>>
>>
>> And then the strcats and sprintfs. If I have more than
>> 20 or so objects under the cursor, Blender will segfault :)
>>
>> | alexander ewering              instinctive mediaworks
>> | ae[@]instinctive[.]de   http://www[.]instinctive[.]de
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers@blender.org
>> http://www.blender.org/mailman/listinfo/bf-committers
>>
>>
>
>


-- 
Campbell J Barton

133 Hope Street
Geelong West, Victoria 3218 Australia

URL:    http://www.metavr.com
e-mail: cbarton@metavr.com
phone: AU (03) 5229 0241