[Bf-committers] Patch for constrain-to-plane

Martin Poirier bf-committers@blender.org
Sun, 25 Jan 2004 20:08:01 -0800 (PST)

--- Bill Baxter <baxter@cs.unc.edu> wrote:
> Ooops.  I left one debug printf in there...  Here's
> the patch with it 
> removed.
> I guess the other thing I should have said could be
> improved is:
> - The kinda confusing overall.  There's this ax
> variable and an axismode 
> variable, and ax was holding just single a axis, so
> thinking over it in 
> retrospect, I think the ax variable was meant to be
> just an indicator of 
> the current typein field.  But with
> constrain-to-plane, 'ax' sometimes 
> needs two values now... well I probably didn't
> handle the code for that 
> so gracefully.  Instead of changing it to hold axis
> flags or something 
> so it could have two values, I just kinda worked
> around it by using the 
> axismode flags sometimes.   Probably would have been
> cleaner to make 
> 'ax' always have the proper axes for typein instead.
>  I just didn't 
> realize that was 'ax's job when I started.

Another reason why the function needs to be reworked.
A lot of variables are only needed in some case, 80%
of them are uncommented as to what they are for, and
the code keep branching everywhere for particular
cases related to each transformation and related


Do you Yahoo!?
Yahoo! SiteBuilder - Free web site building tool. Try it!