[Bf-committers] faceselect undo

Brecht Van Lommel bf-committers@blender.org
09 Feb 2004 00:24:15 +0000


Hi,

I've found a bug in the current undo system, that would crash blender.
You can trigger it by doing this:

- switch to editmode
- fill the undo buffer, by doing 32 or more actions (number depends on
your undo buffer size)
- press alt+U
- select the last step in the list, to go 32 steps back
- blender segfaults

Blender crashes because it tries to restore an undo step that was
already pushed off the stack, by the undo_push_mesh("U"); called in
undo_pop_mesh. Here is a (bf-blender) patch to fix the problem:

http://users.pandora.be/blendix/blender/patch_undo_crash.txt

I have also updated my faceselect undo patch. It now uses separators in
the undo history and alt+U menu to show that which undo steps happened
in which mode. An example of what the menu can look like:

...
Scale
Rotate
-----------------
Face Select Mode
Unwrap
Scale
Rotate UVs
-----------------
Edit Mode
Select Linked
Grab Proportional
......

Bf-blender patch:
http://users.pandora.be/blendix/blender/patch_undo_2.txt

Tuhopuu patch:
http://users.pandora.be/blendix/blender/patch_undo_2_tuhopuu.txt

Cheers,
Brecht