[Bf-committers] 8192 image size overflow

[Ton Roosendaal]

Hi,

I just committed the fix as mentioned below, also found one (old) other  
reference for it.

Someone pointed me to this image:
http://visibleearth.nasa.gov/cgi-bin/viewrecord?11643
there you can get a 8192 x 4096 test image.

At Windows it seems to crash when you use it as Texture with MipMap  
set, and render with OSA. Here at OSX 2.28c ran fine though... weird.

Since I have a relative slow machine without much memory, can others  
test it further? Be warned that testing this image already eats 350  
megs or more.

-Ton-



On Tuesday, Sep 23, 2003, at 03:08 Europe/Amsterdam, Kester Maddock  
wrote:

> Found this problem: filter.c uses:
>
> short step = imbuf->x << 2
>
> IE it overflows for images >= 8192 pixels wide.
>
> If fixing this doesn't fix the user's problem, then it's gotta be  
> something in
> the Windows window handling code.
>
> Kester
>
> PS apart from this, the Valgrind was really boring! :)
>
> On Monday 22 September 2003 15:55, Kester Maddock wrote:
>> On Linux, GeForceFX 5200 1GB Ram I get:
>>
>> Memoryblock free: pointer not in memlist
>> Malloc returns nill: len=233280000 in imb_addrectImBuf
>> Segmentation fault
>>
>> If I add another GB of swap, it renders, but with:
>> Memoryblock free: pointer not in memlist
>>
>> and
>> Memoryblock imb_addrectImBuf: end corrupt
>> when Blender exits, but it doesn't crash.
>>
>> The scene is of the Earth, with James Hastings Trew's 10k textures -  
>> the
>> total amount of memory used is ~ 1700M
>>
>> Can you post the .blend or try with more memory?
>>
>> I'll give it a run through Valgrind to try to trace those Memoryblock
>> errors.
>>
>> Kester
>>
>> On Sunday 21 September 2003 05:28, Tomas Golembiovsky wrote:
>>> I made some researches and it probably isn't problem with graphics
>>> cards. Can somebody confirm this bug on platforms *other* than  
>>> Windows?
>>>
>>> Ton Roosendaal wrote:
>>>> Dudes!
>>>>
>>>> This bug is popping up a while now:
>>>>
>>>> --------------
>>>> http://projects.blender.org/tracker/
>>>> ?func=detail&atid=125&aid=475&group_id=9
>>>>
>>>> During blender is rendering a image, We press F12
>>>> button, Then Blender is crashed after rendering is
>>>> finished.
>>>>
>>>> When crash, dos window displays "GHOST event error -
>>>> invalid window-win:00F6C30(example)" or
>>>> sometime "Memoryblock free:attempt to free NULL
>>>> pointer". It happened when blender is rendering heavy
>>>> scene(spend much memory).
>>>> I tested this problem, Blender crashed with access
>>>> violation.
>>>> -------------
>>>>
>>>> The 'ghost event error' pops up more often it seems...
>>>> The person who fixes it gets eternal fame!
>>>>
>>>> -Ton-
>>>>
>>>> -------------------------------------------------------------------- 
>>>> ---
>>>> - -- Ton Roosendaal  Blender Foundation ton@blender.org
>>>> http://www.blender.org
>>>>
>>>> _______________________________________________
>>>> Bf-committers mailing list
>>>> Bf-committers@blender.org
>>>> http://www.blender.org/mailman/listinfo/bf-committers
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers@blender.org
>> http://www.blender.org/mailman/listinfo/bf-committers
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers@blender.org
> http://www.blender.org/mailman/listinfo/bf-committers
>
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton@blender.org  
http://www.blender.org