[Bf-committers] Re: FILE_MAX defines
Ton Roosendaal
bf-committers@blender.org
Wed, 21 May 2003 14:56:35 +0200
Hi,
Put it in BKE_utildefines.h, thats were it should reside.
But you could check why is was in the other files as well. :-)
in DNA_sequence_types.h:
Stripelem can become 80 long (only filename).
Put 160 in Strip then (dir name).
Add a /* comment */ that the values are derived from the #define.
In the fileselector these defines should have been used for checking...
so you're free to correct that.
Thanks!
-Ton-
On Wednesday, May 21, 2003, at 14:39 Europe/Amsterdam, Holger Haase
wrote:
> Hello,
>
> but there's no reason against putting them into one header file, right?
> And to adjust sizes like that of StripElem? And to check the length in
> the file-selector to bring up a reasonable error-message instead of
> just crashing blender?
>
> ... history can be very sticky;-) ...
>
> -
> holger
>
>> In the past we introduced the two defines to be used in Blender
>> everywhere, and since some strings only need to contain a directory
>> name or file name, we introduced FILE_MAXDIR and FILE_MAXFILE.
>>
>> The values for it (160, 80) are hardcoded in the structures that are
>> in
>> the Blender DNA system, because it cannot read #defines. I would
>> recommend to keep using these values and defines, also to communicate
>> Blender doesn't (cannot) use OS specific defines for it. We also don't
>> use OS specific widgets, so no reason to be compatible with it.
>>
>> Please lets stick with it. :)
>>
>> -Ton-
>
> _______________________________________________________________________
> _____
> Jetzt bei WEB.DE FreeMail anmelden = 1qm Regenwald schuetzen! Helfen
> Sie mit! Nutzen Sie den Serien-Testsieger. http://user.web.de/Regenwald
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers@blender.org
> http://www.blender.org/mailman/listinfo/bf-committers
>
>
------------------------------------------------------------------------
--
Ton Roosendaal Blender Foundation ton@blender.org