[Bf-committers] edgeRender patch

Ton Roosendaal bf-committers@blender.org
Thu, 27 Mar 2003 13:41:10 +0100


Hi,

First, by default (as agreed on) all chars are unsigned in Blender. No  
need to add that to the code.

Second, the float is weird there, I agree. Don't know who wrote that  
code... someone not familiar with fixed point arith I guess. Your  
change should work fine.

-Ton-


On Friday, Mar 28, 2003, at 03:20 Europe/Amsterdam, Jeroen Lamain wrote:

>
> Hi guys,
>
> I removed floating point calculations from addEdgeOver in edgeRender.c
>
> I think the fixed point mathematics are correct. can someone check ?
> The clipping if's are not necessary anymore because
> (255-alpa)*src+(alpha*dst) can never be greater than 256*255.
>
> Please correct me if I'm wrong.
>
> Groetjes,
>
> Jeroen
>
>
>
> <edgeRender.diff>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton@blender.org